build: improve source map configuration for better debugging #31415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
fix/debugging
branch
from
59e8fa0 to
8870a40
Compare
This commit refactors the jasmine_test rule in tools/defaults.bzl to use the centralized version from @devinfra//bazel/jasmine:jasmine.bzl. This simplifies the rule by removing manual source-map-support handling. Source map generation has been standardized across the project by enabling the sourceMap option in the root tsconfig.json and removing conflicting inline source map settings from test-specific configurations. These changes significantly improve the developer experience by enabling breakpoints to be set directly within TypeScript source files when debugging tests in editors like VSCode. Additionally, the exclusion rules for .vscode/tasks.json and .vscode/launch.json have been removed from .gitignore, aligning with the standard practice of not tracking user-specific editor configurations.
alan-agius4
force-pushed
the
fix/debugging
branch
from
8870a40 to
d06d2d2
Compare
jkrems
approved these changes
Oct 8, 2025
alan-agius4
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the jasmine_test rule in tools/defaults.bzl to use the centralized version from @devinfra//bazel/jasmine:jasmine.bzl. This simplifies the rule by removing manual source-map-support handling.
Source map generation has been standardized across the project by enabling the sourceMap option in the root tsconfig.json and removing conflicting inline source map settings from test-specific configurations.
These changes significantly improve the developer experience by enabling breakpoints to be set directly within TypeScript source files when debugging tests in editors like VSCode.